Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion: Delegate kitty +complete to kitten #5977

Closed
wants to merge 2 commits into from

Conversation

page-down
Copy link
Contributor

  • Delegate kitty +complete to kitten.
  • Implement kitten __complete__ setup in Go.
  • Fix zsh completion script to check kitten.

After the PR is merged, I will probably submit a PR to the fish project for the following completion scripts.

# fish-shell/share/completions/kitty.fish
if command -q kitten
    kitten __complete__ setup fish kitty | source -
else ... 

# fish-shell/share/completions/kitten.fish
kitten __complete__ setup fish kitten | source -

Please review, thanks.

Implement `kitten __complete__ setup` in Go.
Fix zsh completion script to check `kitten`.
@page-down
Copy link
Contributor Author

This PR has been merged.

9adc474

@page-down page-down closed this Feb 3, 2023
@page-down page-down deleted the completion branch February 3, 2023 10:51
@page-down
Copy link
Contributor Author

@kovidgoyal

Oh, I forgot to mention that there is a problem with bash completion.
kitten @launch will be completed as kitten launch.

Maybe take a look at this when you have time.

@page-down
Copy link
Contributor Author

bash 5.1.16, 5.2.15
When bash-completion is not installed, COMP_WORDBREAKS is "'@><=;|&(:.

- `kitten @lau`
- Press Tab, `COMP_WORDS` -> (`kitten`, `@`, `lau`), `COMPREPLY+=('launch')`
- `kitten launch`

I am not sure if there is a appropriate way to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant