macOS: Fix the maximized window not taking up full screen space and other improvements#6035
Merged
Merged
Conversation
Fix the maximized window can't occupy full screen space when window decoration or title bar is hidden. Fix resize_in_steps being applied even when window is maximized. Allows to specify `os_window_state` in startup session file.
When the remembered window size is the full screen height, the window height decreases after hiding the title bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resize_in_stepsis configured.os_window_statein startup session file.Various combinations of configuration option values that I can think of have been tested.
I'm not quite sure how to create a window with the specified state directly under wayland and x11, so I left it untouched.
If it can be started in various states, rather than created and then changed, then the first time the window is restored to the normal state it needs to be restored to the remembered window size or the configured fixed size, and
resize_in_stepsshould be applied.Fixes #5863 #6021
Previous Discussion:
#6026