Extend placement_strategy options#7419
Merged
kovidgoyal merged 1 commit intokovidgoyal:masterfrom May 8, 2024
Merged
Conversation
placement_strategy previously only accepted 'center' and 'top-left', but others are potentially useful too. I personally like 'bottom-left'. The new set of accepted values mirrors the window_logo_position option.
jwueller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
placement_strategyonly acceptscenterandtop-leftat the moment, but I'm personally a fan ofbottom-leftplacement. This PR extends the set of accepted values to the same set accepted by thewindow_logo_positionoption.