More panel options#8068
Merged
kovidgoyal merged 5 commits intokovidgoyal:masterfrom Nov 25, 2024
robin-carlier:more_panel_options
Merged
More panel options#8068kovidgoyal merged 5 commits intokovidgoyal:masterfrom robin-carlier:more_panel_options
kovidgoyal merged 5 commits intokovidgoyal:masterfrom
robin-carlier:more_panel_options
Conversation
kovidgoyal
reviewed
Nov 24, 2024
kovidgoyal
reviewed
Nov 24, 2024
kovidgoyal
reviewed
Nov 24, 2024
kovidgoyal
reviewed
Nov 24, 2024
Owner
|
I am fine with adding a flag to control exclusive_zone. |
Contributor
Author
I split it into two flags: |
Owner
|
Merged. It might be good to add some "recipes" or cookbook style |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally found some time to implement what we discussed (and a bit more) in #8007
The main additions/modifications are
--layeroption for the kitten panel to specify on which layer the panel should be drawn.--edge=noneoption for the kitten, when set, the width, height and margins of the kitten can be freely set to get some flexibility in the geometry. When set, the panel leaves its exclusive_zone to-1, so it might get drawn on top of other things. Maybe we could also add a flag to conthol this as well?--linesand--columsare now split as two distinct parameters to control the size (in cells) when using--edge=none.--margin-...options to set some margin if desired.focus-policyflag.With this, I think the kitten should be reasonably flexible to be used in fun ways.
I could test that the options behave as expected using Hyprland, but I don’t know if they do for other compositors.