Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedded bitmap glyphs #934

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Add support for embedded bitmap glyphs #934

merged 2 commits into from
Sep 9, 2018

Conversation

mahmadzaid
Copy link
Contributor

@mahmadzaid mahmadzaid commented Sep 8, 2018

Tested with Terminus (TTF) using the recommended font sizes, seems to fix issues mentioned in #106.
This doesn't add support for bitmap fonts.

@kovidgoyal kovidgoyal merged commit 739ed90 into kovidgoyal:master Sep 9, 2018
@kovidgoyal
Copy link
Owner

I have merged. However, I have once concern. When iterating over the pixels in the bitmap should you be using bitmap->pitch? See for example the downsample_function which uses a stride (calculated from the bitmap pitch)

@mahmadzaid
Copy link
Contributor Author

Yes, however, according to the docs, the pitch of the bitmap is a multiple of alignment (in our case it's 1), making it equal to the bitmap width.
Thanks.

@kovidgoyal
Copy link
Owner

OK, just to be explicit I have changed it to use pitch, since that is its stated purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants