Add option to increase font thickness on macOS #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kovidgoyal
reviewed
Sep 11, 2018
|
|
||
| o('macos_thicken_font', 0, option_type=positive_float, long_text=_(''' | ||
| Draw an extra border around the font with the given width, to increase | ||
| legibility at small font sizes. |
Owner
There was a problem hiding this comment.
Maybe add a suggested value or two so people have somewhere to start.
Contributor
Author
There was a problem hiding this comment.
A value of 0.75 gives approximately the same result as enabling subpixel antialiasing. How does that sound?
kovidgoyal
reviewed
Sep 11, 2018
| CGContextSetTextPosition(render_ctx, 0, height - baseline); | ||
| CTFontDrawGlyphs(font, glyphs, positions, num_glyphs, render_ctx); | ||
| CGContextRelease(render_ctx); | ||
| CGColorSpaceRelease(gray_color_space); |
Owner
There was a problem hiding this comment.
I have already added the missing release calls to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.