Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

changed activerecord/activesupport dependency version from <= 3.2.3 to ~> 3.2.3 #49

Closed
wants to merge 1 commit into from

5 participants

@omcnet

No description provided.

@omcnet

Is there any test that is necessary to merge this change?
We have been using this db-charmer version with rails 3.2.8 for month without any issue.

@ktham

I'm wondering that too, I would like to use your gem but with rails 3.2.8 without having to make the change on dependency myself

@kovyrin
Owner

The issue with this and other pull requests is that they all break db-charmer test suite. Rails core team changed some internals of ActiveRecord in 3.2.4 and the tests break on all Rails versions since then. I simply do not have time to figure out what is wrong with those new versions but I do not want to deceive db-charmer users into believing that the gem is compatible with new Rails when it could very well be completely broken.

So, if you need to use newer version of rails, feel free to create a fork, change those 2 lines and use bundler :git to fetch your custom version until the official one with a proper fix will be available.

@omcnet

Hey,
thanks for your reply. I believe the tests are not part of the repository, or am I missing something?
Since we are using your gem in our company, we might find time to have a look on that issue.

@yellow5

@omcnet have you had success in production with db-charmer after changing the dependency? i just started a task to upgrade some apps that use this gem to rails 3.2.8 and found out about the dependency limitation.

@kovyrin
Owner

DbCharmer 1.8.0 has been released with support for rails versions up to 3.2.9: https://rubygems.org/gems/db-charmer/versions/1.8.0.

@kovyrin kovyrin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 24, 2012
  1. @omcnet
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 db-charmer.gemspec
View
4 db-charmer.gemspec
@@ -20,8 +20,8 @@ Gem::Specification.new do |s|
s.extra_rdoc_files = [ 'LICENSE', 'README.rdoc' ]
# Dependencies
- s.add_dependency 'activesupport', '<= 3.2.3'
- s.add_dependency 'activerecord', '<= 3.2.3'
+ s.add_dependency 'activesupport', '~> 3.2.3'
+ s.add_dependency 'activerecord', '~> 3.2.3'
s.add_development_dependency 'rspec'
s.add_development_dependency 'yard'
Something went wrong with that request. Please try again.