New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#39] Build with GHC 8.2.2 and GHC 8.6.1 on CI #52

Merged
merged 4 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@brandonhamilton
Contributor

brandonhamilton commented Oct 4, 2018

Closes #39

@vrom911

Hey @brandonhamilton! Thanks a lot for your contribution!

CI is still on but I can tell that as we are supporting GHC starting from 8.2.2 and up to 8.4.3 now we should change the base lower bound accordingly – base >= 4.10 && < 4.13. So this version will not break in the future.

@vrom911 vrom911 requested review from ChShersh and vrom911 Oct 4, 2018

@ChShersh ChShersh changed the title from Build with GHC 8.2.2 and GHC 8.6.1 on CI to [#39] Build with GHC 8.2.2 and GHC 8.6.1 on CI Oct 4, 2018

Show outdated Hide outdated co-log-core/co-log-core.cabal Outdated
@vrom911

vrom911 approved these changes Oct 4, 2018

Nice! Thank you very much, this is very useful to have!

@brandonhamilton

This comment has been minimized.

Show comment
Hide comment
@brandonhamilton

brandonhamilton Oct 4, 2018

Contributor

Aha - there is now a build issue on 8.2.2

Contributor

brandonhamilton commented Oct 4, 2018

Aha - there is now a build issue on 8.2.2

@brandonhamilton

This comment has been minimized.

Show comment
Hide comment
@brandonhamilton

brandonhamilton Oct 4, 2018

Contributor

Yes thanks; you've done all the work in figuring out the cause 😉
I will push a fix to this PR

Contributor

brandonhamilton commented Oct 4, 2018

Yes thanks; you've done all the work in figuring out the cause 😉
I will push a fix to this PR

@ChShersh

This comment has been minimized.

Show comment
Hide comment
@ChShersh

ChShersh Oct 4, 2018

Member

@brandonhamilton Sorry, turned out I was wrong (so I've deleted my comment). The old interface was only in the GHC 8.0.2 and the new one appeared in GHC 8.2.2. So this is not actually a reason of error...

Member

ChShersh commented Oct 4, 2018

@brandonhamilton Sorry, turned out I was wrong (so I've deleted my comment). The old interface was only in the GHC 8.0.2 and the new one appeared in GHC 8.2.2. So this is not actually a reason of error...

@ChShersh

This comment has been minimized.

Show comment
Hide comment
@ChShersh

ChShersh Oct 4, 2018

Member

@brandonhamilton Okay, looks like GHC 8.2.2 has total disrespect to forall in MessageField constructor. Writing instance like this solves the issue:

    fromLabel field = TM.WrapTypeable $ MessageField @_ @fieldName field

So I think you still can use -XCPP and resolve this particular issue. But then you will observe the compilation error with README.lhs...

Member

ChShersh commented Oct 4, 2018

@brandonhamilton Okay, looks like GHC 8.2.2 has total disrespect to forall in MessageField constructor. Writing instance like this solves the issue:

    fromLabel field = TM.WrapTypeable $ MessageField @_ @fieldName field

So I think you still can use -XCPP and resolve this particular issue. But then you will observe the compilation error with README.lhs...

@ChShersh

All builds are passing now! 🎉

@ChShersh ChShersh merged commit 7e0f738 into kowainik:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment