Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic-data instead of generic-deriving #363

Closed
chshersh opened this issue Nov 3, 2019 · 0 comments · Fixed by #406
Closed

Use generic-data instead of generic-deriving #363

chshersh opened this issue Nov 3, 2019 · 0 comments · Fixed by #406
Assignees
@chshersh
Labels
library refactoring
Milestone
v2.0: Major update

Comments

@chshersh
Copy link
Contributor

chshersh commented Nov 3, 2019

Currently, usage of generic-deriving requires to implement orphan instances. generic-data has a different design and it's much easier to use it. Also, once we drop support for all GHC below 8.6.5, we can even use DerivingVia with generic-data:

data Config = Config
    { ...
    } deriving (Semigroup, Monoid) via Generically Config
@vrom911 vrom911 changed the title [RFC] Use generic-data instead of generic-deriving Use generic-data instead of generic-deriving Jan 3, 2020
@chshersh chshersh self-assigned this Feb 19, 2020
chshersh added a commit that referenced this issue Feb 19, 2020
@chshersh
[#363] Use generic-data instead of generic-deriving
b5c59f6 
Resolves #363
@chshersh chshersh mentioned this issue Feb 19, 2020
Merged
@chshersh chshersh added this to the v2.0: Major update milestone Feb 19, 2020
chshersh added a commit that referenced this issue Feb 19, 2020
@chshersh
[#363] Use generic-data instead of generic-deriving
989400e 
Resolves #363
chshersh added a commit that referenced this issue Feb 19, 2020
@chshersh
[#363] Use generic-data instead of generic-deriving
1f929b5 
Resolves #363
vrom911 pushed a commit that referenced this issue Feb 19, 2020
@chshersh
[#363] Use generic-data instead of generic-deriving (#406)
1954789 
* [#363] Use `generic-data` instead of `generic-deriving`

Resolves #363

* Make HLint happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chshersh chshersh

Labels
library refactoring
Projects
None yet
Milestone
v2.0: Major update
Development

Successfully merging a pull request may close this issue.

[#363] Use generic-data instead of generic-deriving kowainik/summoner
1 participant
@chshersh