Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis fails for GHC < 8.2 #92

Closed
adituv opened this issue Jun 11, 2018 · 1 comment
Closed

Travis fails for GHC < 8.2 #92

adituv opened this issue Jun 11, 2018 · 1 comment
Labels
bug

Comments

@adituv
Copy link
Contributor

@adituv adituv commented Jun 11, 2018

As title, because -fhide-source-paths was only added in GHC 8.2. Maybe only add it conditionally to the template?

@chshersh chshersh added the bug label Jun 11, 2018
@chshersh

This comment has been minimized.

Copy link
Member

@chshersh chshersh commented Jun 11, 2018

@adituv Thanks for bug report! Yeah, this should be done conditionally in this function:

createStackYamls :: [GhcVer] -> [TreeFs]

Would you like to open pull request with this bug-fix?

@chshersh chshersh added this to the v1.1 Upgrade milestone Jun 11, 2018
adituv added a commit to adituv/summoner that referenced this issue Jun 11, 2018
adituv added a commit to adituv/summoner that referenced this issue Jun 11, 2018
adituv added a commit to adituv/summoner that referenced this issue Jun 11, 2018
@chshersh chshersh closed this in #93 Jun 12, 2018
chshersh added a commit that referenced this issue Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.