Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for GitHub Actions CI (#351). #393
Merged
Conversation
hint-man bot left a comment
|
There is no place for me here... I will choose the truth I like. |
|
Great job! Thanks a lot for this |
summoner-cli/test/golden/fullProject/.github/workflows/haskell.yml
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
This should be ready for another go-round! |
…aaand-action
|
Looks amazing! Thank a lot for your work, time and patience |
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
patrickt commentedDec 27, 2019
•
edited
This PR implements @chshersh’s excellent instructions from #351, adding support for generating a
.github/workflows/haskell.ymlfile compatible withcabal. (Stack support is not present in thesetup-haskellimage, so it’s not supported as of now.) A run of the generated .yml file can be found here. Note that this doesn’t invoke hlint anywhere, pending a resolution to actions/setup-haskell#5.Leaving some comments inline to justify my thought processes.