Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Actions CI (#351). #393

Merged
merged 18 commits into from Jan 3, 2020

Conversation

@patrickt
Copy link
Contributor

patrickt commented Dec 27, 2019

This PR implements @chshersh’s excellent instructions from #351, adding support for generating a .github/workflows/haskell.yml file compatible with cabal. (Stack support is not present in the setup-haskell image, so it’s not supported as of now.) A run of the generated .yml file can be found here. Note that this doesn’t invoke hlint anywhere, pending a resolution to actions/setup-haskell#5.

Leaving some comments inline to justify my thought processes.

@patrickt patrickt requested review from chshersh and vrom911 as code owners Dec 27, 2019
@hint-man
hint-man bot approved these changes Dec 27, 2019
Copy link

hint-man bot left a comment

There is no place for me here... I will choose the truth I like.

summoner-cli/src/Summoner/CLI.hs Show resolved Hide resolved
summoner-cli/src/Summoner/Config.hs Show resolved Hide resolved
summoner-cli/src/Summoner/Project.hs Outdated Show resolved Hide resolved
patrickt added 3 commits Dec 27, 2019
Copy link
Member

vrom911 left a comment

Great job! Thanks a lot for this 💯

summoner-cli/src/Summoner/CLI.hs Show resolved Hide resolved
summoner-cli/src/Summoner/Config.hs Show resolved Hide resolved
summoner-cli/src/Summoner/Project.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Template/GitHub.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Template/GitHub.hs Outdated Show resolved Hide resolved
Copy link
Member

chshersh left a comment

@patrickt Thanks for the PR! This integration looks nice, thanks for your time 🕥 I have a few comments but looks great overall 👍

summoner-cli/src/Summoner/Config.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Template/GitHub.hs Outdated Show resolved Hide resolved
summoner-cli/src/Summoner/Template/GitHub.hs Outdated Show resolved Hide resolved
patrickt and others added 7 commits Dec 30, 2019
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
Co-Authored-By: Dmitrii Kovanikov <kovanikov@gmail.com>
@patrickt

This comment has been minimized.

Copy link
Contributor Author

patrickt commented Jan 2, 2020

This should be ready for another go-round!

@patrickt patrickt requested review from vrom911 and chshersh Jan 2, 2020
@vrom911
vrom911 approved these changes Jan 3, 2020
Copy link
Member

vrom911 left a comment

Looks amazing! Thank a lot for your work, time and patience 💯

Copy link
Member

chshersh left a comment

Great! Thanks!

@vrom911 vrom911 merged commit c22a243 into kowainik:master Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vrom911 vrom911 mentioned this pull request Jan 3, 2020
1 of 2 tasks complete
@patrickt patrickt deleted the patrickt:aaaaand-action branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.