New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Started on a Spanish version, but minimorph Spanish support will be needed. #1

Merged
merged 1 commit into from Dec 13, 2012

Conversation

Projects
None yet
2 participants
@DrDub
Contributor

DrDub commented Dec 13, 2012

The current patch can help highlight some changes needed for multilingual support.

Gender and number information about the referrent is needed for proper determiner
agreement. Compare:

"una hormiga" vs "un sombrero" vs "unas hormigas" vs "unos sombreros"

And 'a sombrero' is not valid Spanish, it should be 'un sombrero' :-)

Started on a Spanish version, but minimorph Spanish support will be n…
…eeded.

The current patch can help highlight some changes needed for multilingual support.

Gender and number information about the referrent is needed for proper determiner
agreement. Compare:

"una hormiga" vs "un sombrero" vs "unas hormigas" vs "unos sombreros"

And 'a sombrero' is not valid Spanish, it should be 'un sombrero' :-)
@kowey

This comment has been minimized.

Show comment
Hide comment
@kowey

kowey Dec 13, 2012

Owner

Hey, thanks! This is quite cool to see

It's going to take me a little while to merge this, particularly since I've
misplaced my copy of the darcs bridge, but I will get to it

Are you thinking of also doing the minimorph stuff?
See http://hub.darcs.net/kowey/minimorph

On Thursday, 13 December 2012, Pablo Duboue wrote:

The current patch can help highlight some changes needed for multilingual
support.

Gender and number information about the referrent is needed for proper
determiner
agreement. Compare:

"una hormiga" vs "un sombrero" vs "unas hormigas" vs "unos sombreros"

And 'a sombrero' is not valid Spanish, it should be 'un sombrero' :-)

You can merge this Pull Request by running:

git pull https://github.com/DrDub/antfarm master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Started on a Spanish version, but minimorph Spanish support will be
    n…

File Changes

  • M NLP/Antfarm/Demo.hs (17)
  • A NLP/Antfarm/Spanish.hs (65)
  • M antfarm.cabal (2)
  • M test/NLP/AntfarmTest.hs (26)

Patch Links

Eric Kow http://erickow.com

Owner

kowey commented Dec 13, 2012

Hey, thanks! This is quite cool to see

It's going to take me a little while to merge this, particularly since I've
misplaced my copy of the darcs bridge, but I will get to it

Are you thinking of also doing the minimorph stuff?
See http://hub.darcs.net/kowey/minimorph

On Thursday, 13 December 2012, Pablo Duboue wrote:

The current patch can help highlight some changes needed for multilingual
support.

Gender and number information about the referrent is needed for proper
determiner
agreement. Compare:

"una hormiga" vs "un sombrero" vs "unas hormigas" vs "unos sombreros"

And 'a sombrero' is not valid Spanish, it should be 'un sombrero' :-)

You can merge this Pull Request by running:

git pull https://github.com/DrDub/antfarm master

Or view, comment on, or merge it at:

#1
Commit Summary

  • Started on a Spanish version, but minimorph Spanish support will be
    n…

File Changes

  • M NLP/Antfarm/Demo.hs (17)
  • A NLP/Antfarm/Spanish.hs (65)
  • M antfarm.cabal (2)
  • M test/NLP/AntfarmTest.hs (26)

Patch Links

Eric Kow http://erickow.com

@DrDub

This comment has been minimized.

Show comment
Hide comment
@DrDub

DrDub Dec 13, 2012

Contributor

Sure, take your time to merge it :-)

Yes, I'll get to minimorph at some point.
Bug me about it on Twitter if I don't.

Contributor

DrDub commented Dec 13, 2012

Sure, take your time to merge it :-)

Yes, I'll get to minimorph at some point.
Bug me about it on Twitter if I don't.

kowey added a commit that referenced this pull request Dec 13, 2012

Merge pull request #1 from DrDub/master
Started on a Spanish version, but minimorph Spanish support will be needed.

@kowey kowey merged commit 7ccfe61 into kowey:master Dec 13, 2012

@kowey

This comment has been minimized.

Show comment
Hide comment
@kowey

kowey Dec 13, 2012

Owner

Right, merged… well sort of.
Turns out I might not have done it right (from the darcs-bridge perspective)

So in the worst case I may have to nuke my GitHub repo, or partly roll it back or something
But getting there

On 13 Dec 2012, at 06:01, Pablo Duboue wrote:

Sure, take your time to merge it :-)

Yes, I'll get to minimorph at some point.
Bug me about it on Twitter if I don't.


Reply to this email directly or view it on GitHub.

Eric Kow http://erickow.com

Owner

kowey commented Dec 13, 2012

Right, merged… well sort of.
Turns out I might not have done it right (from the darcs-bridge perspective)

So in the worst case I may have to nuke my GitHub repo, or partly roll it back or something
But getting there

On 13 Dec 2012, at 06:01, Pablo Duboue wrote:

Sure, take your time to merge it :-)

Yes, I'll get to minimorph at some point.
Bug me about it on Twitter if I don't.


Reply to this email directly or view it on GitHub.

Eric Kow http://erickow.com

@DrDub

This comment has been minimized.

Show comment
Hide comment
@DrDub

DrDub Dec 14, 2012

Contributor

Sounds good. Regarding minimoprh, excuse my ignorance, but how do I send you darcs "pull requests"? I mail you patches?

Contributor

DrDub commented Dec 14, 2012

Sounds good. Regarding minimoprh, excuse my ignorance, but how do I send you darcs "pull requests"? I mail you patches?

@kowey

This comment has been minimized.

Show comment
Hide comment
@kowey

kowey Dec 14, 2012

Owner

You can darcs record them and then darcs send (some number of patches)

On 14 Dec 2012, at 22:23, Pablo Duboue wrote:

Sounds good. Regarding minimoprh, excuse my ignorance, but how do I send you darcs "pull requests"? I mail you patches?


Reply to this email directly or view it on GitHub.

Eric Kow http://erickow.com

Owner

kowey commented Dec 14, 2012

You can darcs record them and then darcs send (some number of patches)

On 14 Dec 2012, at 22:23, Pablo Duboue wrote:

Sounds good. Regarding minimoprh, excuse my ignorance, but how do I send you darcs "pull requests"? I mail you patches?


Reply to this email directly or view it on GitHub.

Eric Kow http://erickow.com

@kowey

This comment has been minimized.

Show comment
Hide comment
@kowey

kowey Dec 15, 2012

Owner

OK, now merged hopefully the right way.
Sorry, hope me deleting my merge commits didn't mess anything up for you.

Cool! So with the darcs bridge, I can continue using darcs (which I find more flexible and user friendly), but meet people in Git land.

Owner

kowey commented Dec 15, 2012

OK, now merged hopefully the right way.
Sorry, hope me deleting my merge commits didn't mess anything up for you.

Cool! So with the darcs bridge, I can continue using darcs (which I find more flexible and user friendly), but meet people in Git land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment