Fix kernel panic on Broadwell-E/MB. No integrated graphics. #351

Merged
merged 1 commit into from Jan 6, 2017

Projects

None yet

3 participants

@koush
Contributor
koush commented Jan 6, 2017 edited

Only specific CPU models have integrated graphics. Broadwell-MB does not. This unfortunately was not noted in the Broadwell support patches. So, on my 6950X, it would try to read the uncore sensor and kernel panic on the update_counters call.

The uncore sensor support should be explicitly added vs added by default. The failure case when there is no uncore sensor is a kernel panic.

This patch reverses the logic. Instead of opting out various models, it opts in models with the intel Iris graphics. So if a new CPU model comes along, the kext won't require a recompile in case it doesn't have an uncore device. With this patch, the failure case is simply no uncore sensor support.

@koush koush referenced this pull request in RehabMan/OS-X-FakeSMC-kozlek Jan 6, 2017
Open

Fix kernel panic on Broadwell-E (and MB?). No integrated graphics. #9

@kozlek
Owner
kozlek commented Jan 6, 2017

Thanks! You are right it is better not to see an uncore sensor instead of KP.

@kozlek kozlek merged commit 066f0b4 into kozlek:master Jan 6, 2017
@koush
Contributor
koush commented Jan 13, 2017

Any chance of getting a release published? I have my own build, but would prefer to point people to the official downloads.

@kozlek
Owner
kozlek commented Jan 14, 2017

Yes. I'll do it later today

@sincohen

Can you also increase the CPU sensor count? it seems limited to 8 dies, some of us have 10 die CPUs now.

@koush
Contributor
koush commented Jan 16, 2017 edited

@sincohen I don't have that issue with my 6950X. I think you need to fix this line in VoodooTSCSync.kext.

https://github.com/koush/EFI-X99/blob/master/CLOVER/kexts/Other/VoodooTSCSync.kext/Contents/Info.plist#L54

@sincohen

Thanks for the quick reply. I definitely had that set at 19 before, not sure how but at some point it got reverted to 15 (I used to have an 8 core). Nonetheless, while HWsensors shows all core temps, istat still only shows 8. Perhaps this is an istat issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment