Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all output has been read before calling .wait() #36

Closed
kpcyrd opened this issue Dec 6, 2020 · 1 comment
Closed

Ensure all output has been read before calling .wait() #36

kpcyrd opened this issue Dec 6, 2020 · 1 comment

Comments

@kpcyrd
Copy link
Owner

kpcyrd commented Dec 6, 2020

I'm suspecting there's a race with leftover data not being read from a child process if the .wait() future resolves before the last .read(). The parent process should read until the streams are closed before awaiting .wait().
@kpcyrd
Copy link
Owner Author

kpcyrd commented Dec 17, 2021

I think this was resolved in #71 and friends

@kpcyrd kpcyrd closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpcyrd