Adds small QoL improvments to debian workers - #59
Merged
Conversation
kpcyrd
reviewed
Jul 30, 2021
SantiagoTorres
force-pushed
the
debian-docker-worker
branch
from
July 30, 2021 01:09
6311a47 to
e986868
Compare
In order to build debian packages on debian machines, we need a newer suite of mmdebstrap for srebuild. Update to the up-and-coming debian stable (bullseye, now testing) to use a newer (now also explicitly installed) mmdebstrap. Lastly, to keep things consistent between Dockerfiles, use ENTRYPOINT rather than CMD (this also keeps things a little neater when issuing workers for testing) Note: we are using bullseye as a tag for the container stage (and not testing) to ensure a nicer handoff in the coming weeks.
For the sake of my memory, and because it could be helpful to those trying to manage workers as containers, document the process a little bit in its own readme. It goes without saying, the debian docker container needs CAP_SYS_ADMIN, and that's needs to be adequately called out.
SantiagoTorres
force-pushed
the
debian-docker-worker
branch
from
July 30, 2021 17:50
e986868 to
66881fa
Compare
Contributor
Author
|
Done, ready for another roll! :) |
Owner
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following: