Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure backwards compatibility for previous versions of obfsproxy (managed mode) #126

Closed
kpdyer opened this issue Apr 1, 2014 · 1 comment
Closed
Assignees
Milestone

Comments

@kpdyer
Copy link
Owner

@kpdyer kpdyer commented Apr 1, 2014

When running in managed mode we need to support all versions of obfsproxy in the 0.2.x chain.

Currently, we are getting

Traceback (most recent call last):
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/python/log.py", line 88, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/python/log.py", line 73, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
--- <exception caught here> ---
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/internet/selectreactor.py", line 151, in _doReadOrWrite
    why = getattr(selectable, method)()
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/internet/tcp.py", line 215, in doRead
    return self._dataReceived(data)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/twisted/internet/tcp.py", line 221, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/obfsproxy/network/socks.py", line 116, in dataReceived
    self.circuit.dataReceived(self.buffer, self)
  File "/Applications/TorBrowser.app/Tor/PluggableTransports/obfsproxy/network/network.py", line 154, in dataReceived
    self.transport.receivedUpstream(data, self)
exceptions.TypeError: receivedUpstream() takes exactly 2 arguments (3 given)

on obfsproxy 0.2.4. (As tested on OSX.)

@kpdyer kpdyer added this to the 0.2.11 milestone Apr 1, 2014
@kpdyer kpdyer self-assigned this Apr 1, 2014
@kpdyer
Copy link
Owner Author

@kpdyer kpdyer commented Apr 1, 2014

Resolved.

@kpdyer kpdyer closed this Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant