Ex_comparator::equal_subtree does not handle use_props correctly #166

Closed
opened this issue Sep 20, 2019 · 1 comment

Owner

kpeeters commented Sep 20, 2019

 The Ex_comparator::equal_subtree function has a parameter use_props, which can be set to not_at_top. What that should do is that property info is not used at top level, but can be used lower, provided the node at that lower level has parent_rel equal to p_sub or p_super. Right now, it will start looking up properties in a match of \dot{a} with \dot{b} as soon as we reach a and b, which is not correct. This leads to weird substitution errors like the one reported in https://cadabra.science/qa/1327/dotted-indices-are-not-substituted-correctly .
Owner Author

kpeeters commented Sep 21, 2019

 Fixed with commit ed1acdc.
closed this Sep 21, 2019