Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ex_comparator::equal_subtree does not handle use_props correctly #166

Closed
kpeeters opened this issue Sep 20, 2019 · 1 comment

Comments

@kpeeters
Copy link
Owner

commented Sep 20, 2019

The Ex_comparator::equal_subtree function has a parameter use_props, which can be set to not_at_top. What that should do is that property info is not used at top level, but can be used lower, provided the node at that lower level has parent_rel equal to p_sub or p_super. Right now, it will start looking up properties in a match of \dot{a} with \dot{b} as soon as we reach a and b, which is not correct.

This leads to weird substitution errors like the one reported in https://cadabra.science/qa/1327/dotted-indices-are-not-substituted-correctly .

@kpeeters

This comment has been minimized.

Copy link
Owner Author

commented Sep 21, 2019

Fixed with commit ed1acdc.

@kpeeters kpeeters closed this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.