New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Nexus 5 #3

Open
wizche opened this Issue Jan 25, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@wizche

wizche commented Jan 25, 2015

I think the Android implementation is missing something on the turnOff() code. With Nexus 5 the turnOff wasn't working and the flash stayed on.

To fix this I've added camera.StopPreview(); at the end of the turnOff() function.

Thanks for the great work!

@srmoss

This comment has been minimized.

Show comment
Hide comment
@srmoss

srmoss Dec 23, 2016

Additionally, the fix you have on Line 68 of the LampImplementation does not work on the second call for 6.x devices. The fix for this is to move it to before the camera.StartPreview() at the end of turnOn() AND add the camera.StopPreview() at the end of turnOff().

srmoss commented Dec 23, 2016

Additionally, the fix you have on Line 68 of the LampImplementation does not work on the second call for 6.x devices. The fix for this is to move it to before the camera.StartPreview() at the end of turnOn() AND add the camera.StopPreview() at the end of turnOff().

srmoss added a commit to srmoss/Xamarin.Plugins that referenced this issue Dec 23, 2016

Fix Issue #3
Move Nexus 5 fix and add camera.stopPreview()

@srmoss srmoss referenced a pull request that will close this issue Dec 23, 2016

Open

Fix Issue #3 #8

@srmoss

This comment has been minimized.

Show comment
Hide comment
@srmoss

srmoss Dec 23, 2016

FYI, more info about why this fix works:
Android Documentation

srmoss commented Dec 23, 2016

FYI, more info about why this fix works:
Android Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment