From 2cbaaff57ae03e73727a7db22da8e7ccfa63b8db Mon Sep 17 00:00:00 2001 From: John Belamaric Date: Fri, 12 May 2023 13:22:36 -0700 Subject: [PATCH] Update status for all reconcile errors (#3960) --- .../packagevariantset/packagevariantset_controller.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/porch/controllers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go b/porch/controllers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go index 7d6864871..d5b7b6d1a 100644 --- a/porch/controllers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go +++ b/porch/controllers/packagevariantsets/pkg/controllers/packagevariantset/packagevariantset_controller.go @@ -108,7 +108,8 @@ func (r *PackageVariantSetReconciler) Reconcile(ctx context.Context, req ctrl.Re setStalledConditionsToTrue(pvs, "NoMatchingTargets", err.Error()) return ctrl.Result{}, nil } - return ctrl.Result{}, err + setStalledConditionsToTrue(pvs, "UnexpectedError", err.Error()) + return ctrl.Result{}, nil } meta.SetStatusCondition(&pvs.Status.Conditions, metav1.Condition{ @@ -120,7 +121,8 @@ func (r *PackageVariantSetReconciler) Reconcile(ctx context.Context, req ctrl.Re err = r.ensurePackageVariants(ctx, pvs, repoList, upstreamPR, downstreams) if err != nil { - return ctrl.Result{}, err + setStalledConditionsToTrue(pvs, "UnexpectedError", err.Error()) + return ctrl.Result{}, nil } meta.SetStatusCondition(&pvs.Status.Conditions, metav1.Condition{