Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: packagevariant controller: support namespacing target packages #3820

Closed

Conversation

natasha41575
Copy link
Contributor

@natasha41575 natasha41575 commented Feb 16, 2023

Not yet ready for review.

Related issue: #3488

Adds the set-namespace function to target downstream packages using the package-context pattern. This should result in the target packages' resources ending up with the specified namespace set on them.

@johnbelamaric
Copy link
Contributor

Thanks Natasha. I don't necessarily want to tie this directly to the package context pattern. In fact, I think that pattern is already supported without this change. If the user sets the package name as different from the upstream, and adds set-namespace in the package Kptfile, I think the existing code should already handle this.

The package context pattern for set-namespace is really around packages whose purpose is to provision namespaces - that is, the package name matches the namespace name. The idea of putting namespace in here is for packages that need to be installed in a namespace, we are making namespace and explicit input to the package variant. It's really a special case of general "mutation" that we are building in directly since it is so common.

Along those lines, I have been talking pretty extensively with the Nephio team on what we need from PackageVariant and would like to evolve the API a bit. I will put in a PR for a design proposal that evolves this to the next step, and then once we all agree I'll work on implementation along with whoever is able to contribute.

@natasha41575
Copy link
Contributor Author

Thanks for your feedback @johnbelamaric! If I am interpreting your comment correctly, this PR is not needed and you are planning to submit a design proposal for api changes that you/Nephio need.

In that case, I'll close this PR, focus on getting #3764 merged, and await your proposal.

@johnbelamaric
Copy link
Contributor

Oh, I didn't actually mean that, but I think it's OK to pause on this PR until the proposal is ready and we can debate it.

@natasha41575 natasha41575 deleted the packagevariantnamespacing branch February 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants