Document `touch` commands time #188

Closed
JensRantil opened this Issue Jun 20, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@JensRantil
Contributor

JensRantil commented Jun 20, 2013

The API documentation states that

The "touch" command allows a worker to request more time to work on a job.

However, it does not state how much more time the client is given. How long is it?

@JensRantil

This comment has been minimized.

Show comment
Hide comment
@Perlover

This comment has been minimized.

Show comment
Hide comment
@Perlover

Perlover Jun 20, 2013

https://raw.github.com/kr/beanstalkd/master/doc/protocol.txt

The stats-job command gives statistical information about the specified job if
it exists. Its form is:

stats-job <id>\r\n

 - "time-left" is the number of seconds left until the server puts this job
   into the ready queue. This number is only meaningful if the job is
   reserved or delayed. If the job is reserved and this amount of time
   elapses before its state changes, it is considered to have timed out.

It has been documented. It's not enough for you? :)
Or may be it's not what you want?

https://raw.github.com/kr/beanstalkd/master/doc/protocol.txt

The stats-job command gives statistical information about the specified job if
it exists. Its form is:

stats-job <id>\r\n

 - "time-left" is the number of seconds left until the server puts this job
   into the ready queue. This number is only meaningful if the job is
   reserved or delayed. If the job is reserved and this amount of time
   elapses before its state changes, it is considered to have timed out.

It has been documented. It's not enough for you? :)
Or may be it's not what you want?

@kr

This comment has been minimized.

Show comment
Hide comment
@kr

kr Jun 20, 2013

Owner

Confirmed, this is an oversight in the protocol doc.
The touch command should say what it actually does.

Owner

kr commented Jun 20, 2013

Confirmed, this is an oversight in the protocol doc.
The touch command should say what it actually does.

@JensRantil

This comment has been minimized.

Show comment
Hide comment
@JensRantil

JensRantil Jun 20, 2013

Contributor

It has been documented. It's not enough for you? :)

Nope. :) Because I don't consider touch to change the state of a job.

Contributor

JensRantil commented Jun 20, 2013

It has been documented. It's not enough for you? :)

Nope. :) Because I don't consider touch to change the state of a job.

@kr kr closed this in 157d88b Jun 20, 2013

@kr

This comment has been minimized.

Show comment
Hide comment
@kr

kr Jun 20, 2013

Owner

Thanks for the fix!

Owner

kr commented Jun 20, 2013

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment