/pty

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for FreeBSD (copy pty_linux.go) #12

Closed
wants to merge 3 commits into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@bkcsoft @tianon @kr @titanous @unclejack @creack @vieux
@bkcsoft
Contributor

bkcsoft commented Jan 25, 2014

This adds support for FreeBSD
@tianon

This comment has been minimized.

Show comment
Hide comment
@tianon

tianon Jan 25, 2014

+1

tianon commented Jan 25, 2014

+1
@kr

This comment has been minimized.

Show comment
Hide comment
@kr

kr Jan 25, 2014

Owner

Wow, does this really work? I'd have expected pty_darwin.go
to be closer to what FreeBSD needs.
Owner

kr commented Jan 25, 2014

Wow, does this really work? I'd have expected pty_darwin.go
to be closer to what FreeBSD needs.
@tianon

This comment has been minimized.

Show comment
Hide comment
@tianon

tianon Jan 25, 2014

I can confirm that it compiles correctly, but I don't know whether @bkcsoft tested that it works correctly. :)

tianon commented Jan 25, 2014

I can confirm that it compiles correctly, but I don't know whether @bkcsoft tested that it works correctly. :)
@bkcsoft

This comment has been minimized.

Show comment
Hide comment
@bkcsoft

bkcsoft Jan 25, 2014

Contributor

I havn't tested it yet, but it compiles, which pty_darwin.go doesn't.
Would the example in the README.md suffice as a test?
Contributor

bkcsoft commented Jan 25, 2014

I havn't tested it yet, but it compiles, which pty_darwin.go doesn't.
Would the example in the README.md suffice as a test?
@bkcsoft

This comment has been minimized.

Show comment
Hide comment
@bkcsoft

bkcsoft Jan 26, 2014

Contributor

don't merge, didn't work, I'll fix it.
Contributor

bkcsoft commented Jan 26, 2014

don't merge, didn't work, I'll fix it.
@bkcsoft

This comment has been minimized.

Show comment
Hide comment
@bkcsoft

bkcsoft Jan 26, 2014

Contributor

Now it works (tested with the example-code from README.md)
Contributor

bkcsoft commented Jan 26, 2014

Now it works (tested with the example-code from README.md)
@titanous

This comment has been minimized.

Show comment
Hide comment
@titanous

titanous Jan 30, 2014

This needs a gofmt.

titanous commented Jan 30, 2014

This needs a gofmt.
@unclejack

This comment has been minimized.

Show comment
Hide comment
@unclejack

unclejack Jan 30, 2014

+1

unclejack commented Jan 30, 2014

+1
@bkcsoft

This comment has been minimized.

Show comment
Hide comment
@bkcsoft

bkcsoft Jan 30, 2014

Contributor

myes, a ; snuck in there...
Contributor

bkcsoft commented Jan 30, 2014

myes, a ; snuck in there...
@bkcsoft

This comment has been minimized.

Show comment
Hide comment
@bkcsoft

bkcsoft Jan 30, 2014

Contributor

done @titanous
Contributor

bkcsoft commented Jan 30, 2014

done @titanous

@creack creack referenced this pull request Feb 7, 2014

Merged

Add freebsd client support #3985

@creack

This comment has been minimized.

Show comment
Hide comment
@creack

creack Feb 7, 2014

Collaborator

Works like a charm. Waiting for this to merge freebsd support into docker.
Collaborator

creack commented Feb 7, 2014

Works like a charm. Waiting for this to merge freebsd support into docker.
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Feb 10, 2014

+1

vieux commented Feb 10, 2014

+1
@kr

This comment has been minimized.

Show comment
Hide comment
@kr

kr Mar 4, 2014

Owner

Ok I merged this in 76284c5.

So sorry for taking so long.
Owner

kr commented Mar 4, 2014

Ok I merged this in 76284c5.

So sorry for taking so long.

@kr kr closed this Mar 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment