Skip to content

Loading…

Force stop on connect. Otherwise, a failed test never ends #181

Closed
wants to merge 1 commit into from

2 participants

@silvioq

Hi!

I could not solve the cygwin trouble, but with this commit the test continues informing the failed check.

Nothing changes in my Linux (Ubuntu) platform. With this patch I can send the failed cpan report in cygwin. Neither I am an expert on Win. Maybe someone can solve.

Silvio

@kraih
Owner

I'm currently rewriting Mojo::IOLoop, so this could just be fixed soon.

@silvioq

Great!
I'll test in cygwin in the new version, when are ready. Anyway, my principal platform is GNU/Linux, then, this patch has lower priority for me.
Silvio

@kraih
Owner

Ok, new Mojo::IOLoop has landed, let me know if there are still problems.

@kraih kraih closed this
@silvioq

Hi Sebastian!

I tried again some minutes ago and works fine!
Some tests (not important for me) fail, when I try TEST_ONLINE=1 or TEST_HYPNOTOAD=1 ... TEST_MORBO=1 works fine.

@kraih
Owner

Great, those tests are developer only and not important. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Showing with 4 additions and 1 deletion.
  1. +4 −1 t/mojo/ioloop.t
View
5 t/mojo/ioloop.t
@@ -138,7 +138,10 @@ my $connected;
$loop->connect(
address => 'localhost',
port => $port,
- on_connect => sub { $connected = 1 },
+ on_connect => sub {
+ $connected = 1;
+ shift->stop;
+ },
on_error => sub {
shift->stop;
$error = pop;
Something went wrong with that request. Please try again.