Force stop on connect. Otherwise, a failed test never ends #181

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@silvioq

silvioq commented Jul 18, 2011

Hi!

I could not solve the cygwin trouble, but with this commit the test continues informing the failed check.

Nothing changes in my Linux (Ubuntu) platform. With this patch I can send the failed cpan report in cygwin. Neither I am an expert on Win. Maybe someone can solve.

Silvio

@kraih

This comment has been minimized.

Show comment
Hide comment
@kraih

kraih Jul 21, 2011

Owner

I'm currently rewriting Mojo::IOLoop, so this could just be fixed soon.

Owner

kraih commented Jul 21, 2011

I'm currently rewriting Mojo::IOLoop, so this could just be fixed soon.

@silvioq

This comment has been minimized.

Show comment
Hide comment
@silvioq

silvioq Jul 21, 2011

Great!
I'll test in cygwin in the new version, when are ready. Anyway, my principal platform is GNU/Linux, then, this patch has lower priority for me.
Silvio

silvioq commented Jul 21, 2011

Great!
I'll test in cygwin in the new version, when are ready. Anyway, my principal platform is GNU/Linux, then, this patch has lower priority for me.
Silvio

@kraih

This comment has been minimized.

Show comment
Hide comment
@kraih

kraih Jul 24, 2011

Owner

Ok, new Mojo::IOLoop has landed, let me know if there are still problems.

Owner

kraih commented Jul 24, 2011

Ok, new Mojo::IOLoop has landed, let me know if there are still problems.

@kraih kraih closed this Jul 24, 2011

@silvioq

This comment has been minimized.

Show comment
Hide comment
@silvioq

silvioq Jul 25, 2011

Hi Sebastian!

I tried again some minutes ago and works fine!
Some tests (not important for me) fail, when I try TEST_ONLINE=1 or TEST_HYPNOTOAD=1 ... TEST_MORBO=1 works fine.

silvioq commented Jul 25, 2011

Hi Sebastian!

I tried again some minutes ago and works fine!
Some tests (not important for me) fail, when I try TEST_ONLINE=1 or TEST_HYPNOTOAD=1 ... TEST_MORBO=1 works fine.

@kraih

This comment has been minimized.

Show comment
Hide comment
@kraih

kraih Jul 25, 2011

Owner

Great, those tests are developer only and not important. :)

Owner

kraih commented Jul 25, 2011

Great, those tests are developer only and not important. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment