Small change to highlight the %attributes #387

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@MattOates

Just added in multiple=>'multiple' since it's a common thing to want with a select. It makes it a bit more obvious that all extra parameters are translated to attributes too.

@MattOates MattOates Small change to highlight the %attributes
Just added in multiple=>'multiple' since it's a common thing to want with a select. It makes it a bit more obvious that all extra parameters are translated to attributes too.
c9c5b30
@kraih
Owner
kraih commented Oct 5, 2012

To me it looks like the proposed change would do the opposite of what it's intended to do, all other examples consistently use id as random attribute to be passed through. I'm generally in favor of making that behavior more obvious, but it should be consistent for all tag helpers. The patch also doesn't follow our formatting rules and the example output is incorrect.

@kraih kraih closed this Oct 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment