I've made the first batch of changes and feel reasonably confident that they can be safely merged with upstream #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace-graph-v2/uuid.lisp which prevents stepping on a namespace we don't really control. Symbols previously exported in vivace-graph-v2/uuid.lisp from the package "UUID" now exported from the package "VG-UUID"
…ppears to be quicklisp:quickload'able.
Conflicts: triples.lisp
…ropped method in `triple-eql' post merge with upstream.
…c-utils.lisp vivace-graph-v2-docs.lisp * vivace-graph-v2-docs.lisp: New File -- Improving documentation means the existing source will get spread out. Moving docs to dedicated file helps keep the source code less cluttered. * vivace-graph-v2-doc-utils.lisp: Ne File -- Utility functions useful for maintaing documentation of functions, macros, variables, types seperate from the locus of the source defining them. If we ever incorporate the Unicly system this file can be dropped as it duplicates existing functionality already provided by that system. * templates.lisp: Add comments and example implementation to header w/r/t `deftemplate' and use of make-v5-uuid for creation of anonymous nodes in dedicated namespace. Revise documentataion and move to vivace-graph-v2-doc-utils.lisp * uuid-bridge.lisp: Add comments to file header discussing rationale for uuid-bridge, identify which symbols were moved from vivace-graph-v2/data-types.lisp, and discuss differences and changes between vivace-graph-v2/uuid.lisp <--> vivace-graph-v2/uuid-bridge.lisp * triples.lisp (make-anonymous-node-name): Add comment that method currently has no visible callers. (make-anonymous-node): Revise comments w/r/t using make-v5-uuid instead of make-v1-uuid -- apropos comments added to file header of vivace-graph-v2/uuid-bridge.lisp
…SB-THREAD". No longer export `get-spinlock', `release-spinlock', `spinlock-value' from the package "SB-THREAD" its not our namespace. (vg-get-spinlock): Renamed from `my-get-spinlock'. Now explicitly evaluate symbols with their fully SBCL package names, e.g. "SB-THREAD", "SB-SYS", etc. (vg-current-thread): New Function. with reader conditional for #-sbcl wraps bordeaux-threads:current-thread. (vg-current-thread-spinlock-value-check): New Function. Abstraction for the `sb-thread:spinlock-value' eq checks that occur in `acquire-hash-table-lock' and `release-hash-table-lock' in vivace-graph-v2/hash-table.lisp * hash-table.lisp (acquire-hash-table-lock): No longer directly checks value of sb-thread:*current-thread* against `my-get-spinlock' now uses `vg-current-thread-spinlock-value-check' instead. (release-hash-table-lock): No longer directly checks value of sb-thread:*current-thread* against `my-get-spinlock' now uses `vg-current-thread-spinlock-value-check' instead.
* sb-impl.lisp: No longer required. * hash-table.lisp: Consolidate the previous indirection of sb-impl.lisp and sb-thread.lisp to one file. Qualify symbol refs in "SB-<FOO>" packages and reader conditional error messages for functionality where a 1:1 with the equivalent SBCL is not known. * vivace-graph-v2.asd (vivace-graph-v2): Removed component file dependency on sb-thread.lisp and sb-impl.lisp.
…s to equivalent of old `my-get-spinlock'. Added new deftype abstractions `vg-thread' `vg-spinlock'. Separated function definitions according to #-sbcl/#+sbcl reader conditionals (this is ugly but if/when additional implementations are supported it makes writing fall-through cases for non-supported implementations clea(rn)er * triples.lisp: Add commented declaration to allow ID var as ingorable in lambda form of maphash.
Conflicts: triples.lisp
…an call it from hash-table.lisp as well.
…nt-<FOO> functions.
…spacing of make-v4-uuid in transaction.lisp
…sleep 0.000000001) -- it appears to be w/r/t thread spinlocking
…pting to change to 0 -- Prob. for the first time ever I can be glad that SBCL barks when attempting to redefine a constant.
…aults initialization
… notes to globals.lisp that *default-locatation-defaults* is ugly.
…eater-than key ordering relations migrating from utilities.lisp #'less-than/#'greater-than aggregate/automate test-op of vg to incorporate testing of significant dependencies via asdf original hash table based implementation key ordering relations migrating from utilities.lisp #'less-than/#'greater-than key ordering relations migrating from utilities.lisp #'less-than/#'greater-than
…iversal-identifier
…combinations specializing on unicly:unique-universal-identifier
…ods from utilities.lisp -- No need to duplicated a bunch of boiler-plate code. If dispatch is an issue then declare the types.
…y with `cl:make-hash-table' to hash-table.lisp. Update caller in lock.lisp to use `vg-make-hash-table'
…in utilities.lisp to dedicated file.
…ed in `vg-get-spinlock' `get-pool-lock'.
…s for equality/comparison between two objects. Renamed `prolog-equal' -> `vg-equal'. Renamed `less-than' -> `vg-less-than'. Renamed `greater-than' -> `vg-greater-than'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.