Rust setup #2
Merged
Rust setup #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddonym
force-pushed
the
setup
branch
2 times, most recently
from
3622dc6 to
83277cb
Compare
seddonym
force-pushed
the
rust-setup
branch
3 times, most recently
from
872780f to
87f93ce
Compare
Maturin is what ensures the rust code is pip-installable.
seddonym
force-pushed
the
rust-setup
branch
from
87f93ce to
00daaa7
Compare
The tests were passing pathlib.Path objects, but the docs suggested strings. We can add formal support for Path objects separately.
This will ensure the Rust code is formatted consistently, just like the Python.
seddonym
force-pushed
the
rust-setup
branch
from
00daaa7 to
33bdf77
Compare
dooferlad
approved these changes
Sep 13, 2024
dooferlad
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the Rust code from https://github.com/octoenergy/rustfluent, and sets up developer support for Rust, and lays the foundations for creating releases.
I haven't completely figured out the release process - the process I use on Grimp involves pushing straight to main - so I'll tackle that in a separate small PR.