This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
Ignore invalid files with no extension #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 30, 2015 16:25
This commit simply adds a file with no extension and some content to the "Superfluous" fixtures directory. Such a file is a perfectly valid use case. For example, SVN-like versioning systems populate a project with hidden folders that include such files. The pattern is: A non-empty file without an extension. These types of files will currently cause express enrouten to fail, as it will incorrectly identify them as a valid node module, and will try to load them.
This passes today, but I feel it's good to have it around as a safety net.
Instead of just trying to resolve the module, try to load it. Since this block is already surrounded by a try/catch statement it's a safe place to attempt requiring a module. I don't think it's wasted effort, since the whole point of validating the modules is to try to load them later. Also, some very minor refactoring of the extension removal code to make it more readable.
| @@ -0,0 +1 @@ | |||
| Klaatu barada nikto | |||
|
LGTM 👍 |
|
Closed due to branch renaming. Will reconstruct, reopen, and notify you when complete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #73
Instead of just trying to resolve a module during the
isFileModuleverification step, try to load it.Since this block is already surrounded by a try/catch statement it's a safe
place to attempt requiring a module. I don't think it's wasted effort, since
the whole point of validating the modules is to try to load them later.
Also, some very minor refactoring of the extension removal code to make it more readable.