Warning free build #10
Conversation
…handled in switch [-Wswitch]
…Wreturn-type] + make apc_lock_ready reliable
…-Wunused-function]
|
in apc_lock, ready should be set before commencing initialization of the mutex. Theoretically, if two contexts were to call lock_init concurrently, they may both end up initializing the same mutex which can lead to unexpected behaviour. |
|
Ok. |
|
currently the return value is never checked, it is assumed to succeed, so it could also be changed to void, or as you say, should return 0 ... currently void would probably be best, along with throwing an e_error where we would have returned 0, as if execution gets to there, we cannot continue and there is something wrong with the setup. |
|
Ok, now we have only the "return 0" added (the goal of this PR is only to fix all build warning) |
|
Excellent, thanks |
# This is the 1st commit message: implement history list # This is the commit message krakjoe#2: add assert # This is the commit message krakjoe#3: rename variable # This is the commit message krakjoe#4: implementation of eviction logic # This is the commit message krakjoe#5: add comment # This is the commit message krakjoe#6: change define # This is the commit message krakjoe#7: added info # This is the commit message krakjoe#8: remove apc_cache_wlocked_add_history_oldest # This is the commit message krakjoe#9: rename function # This is the commit message krakjoe#10: update info # This is the commit message krakjoe#11: update comment # This is the commit message krakjoe#12: fixed loop (cause an infinite loop) # This is the commit message krakjoe#13: add memo # This is the commit message krakjoe#14: change cleaning timing # This is the commit message krakjoe#15: use macros # This is the commit message krakjoe#16: fixed size # This is the commit message krakjoe#17: update the history in the update process # This is the commit message krakjoe#18: refactor
Here is some fixes (most trivial) which allow a warning free build, even with -Wall and recent gcc (tried with 4.7.2).
Please check 82bebd4