PHP 8 Support

Still doesn't work under PHP 8

[dktapps]

[hfedcba]

Since be6d83e it already seems to work reasonably well. But I'd like full PHP 8 support as well.

@hfedcba you mean by compiling yourself parallel ?

[hfedcba]

you mean by compiling yourself parallel ?

Yes.

[eqmaz]

Hi,

Attempting to compile parallel on Centos for PHP 8.0.2 CLI (Config: ZTS thread safe, op cache + JIT), getting the following compile time error:

         if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) {
                                            ^~~~~~~~~~~~~~
                                            ZEND_TYPE_CE
/tmp/pear/temp/parallel/src/check.c:129:85: warning: implicit declaration of function ‘ZEND_TYPE_IS_CLASS’; did you mean ‘ZEND_TYPE_HAS_CLASS’? [-Wimplicit-function-declaration]
         if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) {
                                                                                     ^~~~~~~~~~~~~~~~~~
                                                                                     ZEND_TYPE_HAS_CLASS
/tmp/pear/temp/parallel/src/check.c:139:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’
         if (it->pass_by_reference) {
               ^~
/tmp/pear/temp/parallel/src/check.c:165:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’
         if (it->pass_by_reference) {
               ^~
/tmp/pear/temp/parallel/src/check.c: In function ‘php_parallel_check_class_inline’:
/tmp/pear/temp/parallel/src/check.c:538:13: warning: implicit declaration of function ‘ZEND_TYPE_IS_CE’; did you mean ‘ZEND_TYPE_IS_SET’? [-Wimplicit-function-declaration]
         if (ZEND_TYPE_IS_CE(info->type)) {
             ^~~~~~~~~~~~~~~
             ZEND_TYPE_IS_SET
make: *** [Makefile:224: src/check.lo] Error 1
ERROR: `make' failed

Thanks

[capsandiego]

Could you please send the full configure command?

…

On Wed, 17 Feb 2021, 19:14 eqmaz, ***@***.***> wrote: Hi, Attempting to compile parallel on Centos for PHP 8.0.2 CLI (Config: ZTS thread safe, op cache + JIT), getting the following compile time error: if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) { ^~~~~~~~~~~~~~ ZEND_TYPE_CE /tmp/pear/temp/parallel/src/check.c:129:85: warning: implicit declaration of function ‘ZEND_TYPE_IS_CLASS’; did you mean ‘ZEND_TYPE_HAS_CLASS’? [-Wimplicit-function-declaration] if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) { ^~~~~~~~~~~~~~~~~~ ZEND_TYPE_HAS_CLASS /tmp/pear/temp/parallel/src/check.c:139:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’ if (it->pass_by_reference) { ^~ /tmp/pear/temp/parallel/src/check.c:165:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’ if (it->pass_by_reference) { ^~ /tmp/pear/temp/parallel/src/check.c: In function ‘php_parallel_check_class_inline’: /tmp/pear/temp/parallel/src/check.c:538:13: warning: implicit declaration of function ‘ZEND_TYPE_IS_CE’; did you mean ‘ZEND_TYPE_IS_SET’? [-Wimplicit-function-declaration] if (ZEND_TYPE_IS_CE(info->type)) { ^~~~~~~~~~~~~~~ ZEND_TYPE_IS_SET make: *** [Makefile:224: src/check.lo] Error 1 ERROR: `make' failed Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#170 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHYGIADE6SQBC2LCGMZORTS7QBPJANCNFSM4WH2GDXA> .

[eqmaz]

Could you please send the full configure command?
…
On Wed, 17 Feb 2021, 19:14 eqmaz, @.***> wrote: Hi, Attempting to compile parallel on Centos for PHP 8.0.2 CLI (Config: ZTS thread safe, op cache + JIT), getting the following compile time error: if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) { ^~~~~~~~~~~~~~ ZEND_TYPE_CE /tmp/pear/temp/parallel/src/check.c:129:85: warning: implicit declaration of function ‘ZEND_TYPE_IS_CLASS’; did you mean ‘ZEND_TYPE_HAS_CLASS’? [-Wimplicit-function-declaration] if (ZEND_TYPE_IS_SET(it->type) && (ZEND_TYPE_CODE(it->type) == IS_OBJECT || ZEND_TYPE_IS_CLASS(it->type))) { ^~~~~~~~~~~~~~~~~~ ZEND_TYPE_HAS_CLASS /tmp/pear/temp/parallel/src/check.c:139:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’ if (it->pass_by_reference) { ^~ /tmp/pear/temp/parallel/src/check.c:165:15: error: ‘zend_arg_info’ {aka ‘struct _zend_arg_info’} has no member named ‘pass_by_reference’ if (it->pass_by_reference) { ^~ /tmp/pear/temp/parallel/src/check.c: In function ‘php_parallel_check_class_inline’: /tmp/pear/temp/parallel/src/check.c:538:13: warning: implicit declaration of function ‘ZEND_TYPE_IS_CE’; did you mean ‘ZEND_TYPE_IS_SET’? [-Wimplicit-function-declaration] if (ZEND_TYPE_IS_CE(info->type)) { ^~~~~~~~~~~~~~~ ZEND_TYPE_IS_SET make: *** [Makefile:224: src/check.lo] Error 1 ERROR: `make' failed Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#170 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHYGIADE6SQBC2LCGMZORTS7QBPJANCNFSM4WH2GDXA .

Sure:
./configure --disable-cgi --enable-debug --enable-zts --enable-opcache --enable-opcache-jit --enable-gd --enable-bcmath --enable-mbstring --enable-pcntl --without-sqlite3 -with-mysqli --with-curl --with-zip --with-openssl --enable-phar --with-pear --prefix=/usr --with-config-file-path=/etc

[capsandiego]

I think the issue is that php 8 still has some incompatibilities with --enable-zts.
On my servers, this simple configure fails during compilation (apparently because of ext/opcache/jit )

sudo ./configure --prefix=/usr/local/php/8.0.2 --enable-zts && sudo make -j16

Are you able to compile this?

[dktapps]

be6d83e should have addressed the compile failures. You need to use the latest git source (the releases don't support 8.0 to the best of my knowledge).

[capsandiego]

@dktapps so you can compile this?

sudo ./configure --prefix=/usr/local/php/8.0.2 --enable-zts && sudo make -j16

[dktapps]

Yes. As I said, you need to use the latest git source.

[dktapps]

If you're experiencing issues building PHP itself with ZTS because of JIT, it's likely because of this: https://bugs.php.net/bug.php?id=80561
If you previously built PHP in NTS from the same source, you need to rm ext/opcache/jit/zend_jit_x86.c after running make clean (fixed in 8.0.3RC1: php/php-src@408272b).

[capsandiego]

@dktapps Many thanks, sir!
After your precious suggestions, I confirm it works like a charm with php-8.0.2 and the parallel version you mention.
You just made my day

[eqmaz]

Yes. As I said, you need to use the latest git source.

Thank you sir, for the speedy response. Compiled fine from github repo and appears to work with PHP 8.0.2.

[krakjoe]

PHP 8 support is, I think mostly complete now ... need to find time to do tests ...

The next release of parallel will only support 8.0+