The prompt should always ensure it is on a newline #97

Closed
dshafik opened this Issue Jun 29, 2014 · 1 comment

Projects

None yet

2 participants

@dshafik
Contributor
dshafik commented Jun 29, 2014

When stepping through code and reaching close to the end of the file, which has no trailing newline, the prompt is ends up not being on it's own line:

e.g.

>00043:     <?php
 00044: }
phpdbg> step
    [L44         0x103d95e60 ZEND_JMP                       J16                                                            <file>]
 00043:     <?php
>00044: }
 00045: ?>phpdbg>
@bwoebi bwoebi added a commit that referenced this issue Jun 29, 2014
@bwoebi bwoebi Fix issue krakjoe/phpdbg#97 - list now appends a newline if there is …
…none

The prompt should always ensure it is on a newline
4fde0c2
@bwoebi
Collaborator
bwoebi commented Jun 29, 2014

Thank you, fixed.

@bwoebi bwoebi closed this Jun 29, 2014
@php-pulls php-pulls pushed a commit to php/php-src that referenced this issue Jun 30, 2014
@dstogov dstogov Merge branch 'master' into test
* master: (67 commits)
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  Revert "Fix Bug #67530 	error_log=syslog ignored"
  --enable-fpm for the travis build
  fix the last fpm NEWS entry, the other bug is related, but not the same what we fixed here
  NEWS
  NEWS
  Fix bug #67091: make install fails to install libphp5.so on FreeBSD 10.0
  adding NEWS entry for the fix for bug #65641
  Updated NEWS file for recent phpdbg fixes
  Fixed issue krakjoe/phpdbg#94 - List behavior is inconsistent
  Fix issue krakjoe/phpdbg#97 - list now appends a newline if there is none The prompt should always ensure it is on a newline
  Fixed test
  Inform about back command existence in help - Fixes krakjoe/phpdbg#100 No way to list the current stack/frames
  Fix issue krakjoe/phpdbg#98 break if does not seem to work
  Fix issue krakjoe/phpdbg#99 register function has the same behavior as run
  Fix readline/libedit (Thanks to @remicollet)
  Replace incorrect `E` command with `ev` in watch help
  Fix typo in `finish` help
  ...

Conflicts:
	Zend/zend_ast.c
	Zend/zend_highlight.c
	Zend/zend_indent.c
	ext/spl/spl_array.c
	ext/spl/spl_observer.c
	ext/standard/info.c
acfbb7b
@php-pulls php-pulls pushed a commit to php/php-src that referenced this issue Jul 2, 2014
@weltling weltling Merge remote-tracking branch 'origin/PHP-5.6' into str_size_and_int64…
…_56_backport

* origin/PHP-5.6: (170 commits)
  Fixed possible crash because of race conditions on modifying constants in shared memory
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  Revert "Fix Bug #67530 	error_log=syslog ignored"
  --enable-fpm for the travis build
  fix the last fpm NEWS entry, the other bug is related, but not the same what we fixed here
  NEWS
  NEWS
  Fix bug #67091: make install fails to install libphp5.so on FreeBSD 10.0
  adding NEWS entry for the fix for bug #65641
  Updated NEWS file for recent phpdbg fixes
  Fixed issue krakjoe/phpdbg#94 - List behavior is inconsistent
  Fix issue krakjoe/phpdbg#97 - list now appends a newline if there is none The prompt should always ensure it is on a newline
  Fixed test
  Inform about back command existence in help - Fixes krakjoe/phpdbg#100 No way to list the current stack/frames
  Fix issue krakjoe/phpdbg#98 break if does not seem to work
  Fix issue krakjoe/phpdbg#99 register function has the same behavior as run
  Fix readline/libedit (Thanks to @remicollet)
  Replace incorrect `E` command with `ev` in watch help
  ...

Conflicts:
	Zend/zend_compile.c
	ext/standard/basic_functions.c
	ext/standard/http_fopen_wrapper.c
	ext/standard/var.c
	ext/tokenizer/tokenizer_data.c
	sapi/phpdbg/phpdbg_list.c
1a50c27
@php-pulls php-pulls pushed a commit to php/php-src that referenced this issue Jul 7, 2014
@dstogov dstogov Merge branch 'phpng' into call-frame
* phpng: (73 commits)
  refcount in phpng has different meanings
  Suppress warning "cast from pointer to integer of different size"
  Fixed possible crash because of race conditions on modifying constants in shared memory
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  remove the NEWS entry for the reverted fpm fix
  Revert "Fix Bug #67530 	error_log=syslog ignored"
  Fixed compilation problems
  Refactored parameter passing mechanism.
  --enable-fpm for the travis build
  Fixed segfault while info printing
  fix the last fpm NEWS entry, the other bug is related, but not the same what we fixed here
  NEWS
  NEWS
  Fix bug #67091: make install fails to install libphp5.so on FreeBSD 10.0
  adding NEWS entry for the fix for bug #65641
  Updated NEWS file for recent phpdbg fixes
  Fixed issue krakjoe/phpdbg#94 - List behavior is inconsistent
  Fix issue krakjoe/phpdbg#97 - list now appends a newline if there is none The prompt should always ensure it is on a newline
  Fixed test
  ...
0b1cfdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment