Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try add opcache and coveralls #153

Merged
merged 2 commits into from
Aug 3, 2021
Merged

try add opcache and coveralls #153

merged 2 commits into from
Aug 3, 2021

Conversation

krakjoe
Copy link
Owner

@krakjoe krakjoe commented Aug 3, 2021

No description provided.

@krakjoe
Copy link
Owner Author

krakjoe commented Aug 3, 2021

@cmb69 I've tried a bunch of configurations and don't seem to be able to get opcache to load no matter how I configure it. Not sure why, you have any ideas ?

Note: there is one test that skips when opcache isn't present, I could switch over to using EXTENSIONS, but it's the only way to know if opcache is actually loaded, so first I want to make sure we can enable/disable opcache in the matrix.

@cmb69
Copy link
Collaborator

cmb69 commented Aug 3, 2021

Not sure about OPcache, but don't we need to set uopz.exit=1?

@krakjoe
Copy link
Owner Author

krakjoe commented Aug 3, 2021

We didn't for travis, it should only be necessary in skipif sections which rely on exit working ...

@krakjoe krakjoe merged commit 62d0581 into master Aug 3, 2021
@krakjoe krakjoe deleted the actions-opcache branch August 6, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants