Update external libraries to Eclipse Mars 4.5 #51

Closed
markiewb opened this Issue Jul 12, 2015 · 15 comments

Projects

None yet

3 participants

@markiewb
Contributor

Eclipse Mars 4.5 has been released. Could you update the plugin to use the new jar files from the 4.5 distribution?!

@markiewb
Contributor

I couldn't get the correct combination of jars to update it in my https://github.com/markiewb/eclipsecodeformatter_for_netbeans plugin.
-> Nevermind: Now it is working. I had to add core.runtime as lib and I had to fake a LogFilter interface. markiewb/eclipsecodeformatter_for_netbeans#63

@dkornishev

Sadly Mars code formatter is...different. Will there be an option for using formatter from 4.5?

@krasa
Owner
krasa commented Jul 14, 2015
@dkornishev

The problem is that code formatter in 4.5 actually formats differently than code formatter in 4.4. See
http://eclipse-n-mati.blogspot.com/2015/06/eclipse-mars-how-to-switch-back-to.html for more details.

I don't know what the solution is (new version? bundle both formatters and provide an option?).

@krasa
Owner
krasa commented Jul 15, 2015

damn, I just pushed new libs :-)

We could bundle both versions and use a custom classloader to avoid conflicts.

@krasa
Owner
krasa commented Jul 15, 2015

Actually we could bundle that old formatter eclipse plugin, that's easy.

@dkornishev

Will there be a new version of plugin soon, or will I need to build/install manually?

@krasa krasa added a commit that referenced this issue Jul 15, 2015
@krasa #51 libs from Eclipse Mars 4.5 fe61b4c
@krasa
Owner
krasa commented Jul 15, 2015

Build manually.

Not sure when I will have time to bundle that old formatter.

@dkornishev

I need the new formatter though.
So clone the project and build with intellij plugin builder?

@krasa
Owner
krasa commented Jul 15, 2015

yep

@dkornishev

Instructions? I imported the project but it doesn't even compile. I ran dependency downloader pom and it looks like it fetched stuff but it didn't fix it

@krasa
Owner
krasa commented Jul 15, 2015

you need to configure IntelliJ SDK - https://www.jetbrains.com/idea/help/configuring-intellij-platform-plugin-sdk.html - create new Intellij Platform SDK (just like with Java JDK, and select your installed IntelliJ)

all jars are commited, I just pushed fixed module config, so it should work out of box, otherwise just add those jars as libraries.

it should look like this:
image

@krasa krasa added a commit that referenced this issue Jul 18, 2015
@krasa #51 old java formatter support cd2e0a2
@krasa krasa added a commit that referenced this issue Jul 18, 2015
@krasa #51 typo 2d25009
@krasa
Owner
krasa commented Jul 18, 2015

@dkornishev you can download the builded plugin here: https://github.com/krasa/EclipseCodeFormatter/releases/tag/15.1.132.637.0

I will release it in several days.

@krasa krasa closed this Jul 18, 2015
@krasa
Owner
krasa commented Jul 20, 2015

#52 some of the new libs are compiled with JDK 1.7, I will need to make better OldFormatter jar which does not depend on them or something.

@krasa krasa reopened this Jul 20, 2015
@krasa
Owner
krasa commented Jul 22, 2015

So I have reverted several old jars from Eclipse 4.4 and used a custom classloader + some ugly reflection.

@krasa krasa closed this Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment