From dbe83c0bac1370d14579bca1721a879b75ce6b46 Mon Sep 17 00:00:00 2001 From: Tyler Kovacs Date: Wed, 28 Aug 2013 15:22:20 -0700 Subject: [PATCH] catch all exceptions, not just those that inherit from StandardError --- lib/sidekiq/failures/middleware.rb | 2 +- test/middleware_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sidekiq/failures/middleware.rb b/lib/sidekiq/failures/middleware.rb index 4fab826..1870b26 100644 --- a/lib/sidekiq/failures/middleware.rb +++ b/lib/sidekiq/failures/middleware.rb @@ -10,7 +10,7 @@ def call(worker, msg, queue) yield rescue Sidekiq::Shutdown raise - rescue => e + rescue Exception => e raise e if skip_failure? data = { diff --git a/test/middleware_test.rb b/test/middleware_test.rb index 7be0847..a6217b3 100644 --- a/test/middleware_test.rb +++ b/test/middleware_test.rb @@ -13,7 +13,7 @@ module Failures Sidekiq.instance_eval { @failures_default_mode = nil } end - TestException = Class.new(StandardError) + TestException = Class.new(Exception) ShutdownException = Class.new(Sidekiq::Shutdown) class MockWorker