Skip to content

Commit

Permalink
Fix SPNEGO context aliasing bugs [CVE-2015-2695]
Browse files Browse the repository at this point in the history
The SPNEGO mechanism currently replaces its context handle with the
mechanism context handle upon establishment, under the assumption that
most GSS functions are only called after context establishment.  This
assumption is incorrect, and can lead to aliasing violations for some
programs.  Maintain the SPNEGO context structure after context
establishment and refer to it in all GSS methods.  Add initiate and
opened flags to the SPNEGO context structure for use in
gss_inquire_context() prior to context establishment.

CVE-2015-2695:

In MIT krb5 1.5 and later, applications which call
gss_inquire_context() on a partially-established SPNEGO context can
cause the GSS-API library to read from a pointer using the wrong type,
generally causing a process crash.  This bug may go unnoticed, because
the most common SPNEGO authentication scenario establishes the context
after just one call to gss_accept_sec_context().  Java server
applications using the native JGSS provider are vulnerable to this
bug.  A carefully crafted SPNEGO packet might allow the
gss_inquire_context() call to succeed with attacker-determined
results, but applications should not make access control decisions
based on gss_inquire_context() results prior to context establishment.

    CVSSv2 Vector: AV:N/AC:M/Au:N/C:N/I:N/A:C/E:POC/RL:OF/RC:C

[ghudson@mit.edu: several bugfixes, style changes, and edge-case
behavior changes; commit message and CVE description]

ticket: 8244
target_version: 1.14
tags: pullup
  • Loading branch information
nicowilliams authored and greghudson committed Oct 26, 2015
1 parent e767d9f commit b51b33f
Show file tree
Hide file tree
Showing 2 changed files with 192 additions and 64 deletions.
2 changes: 2 additions & 0 deletions src/lib/gssapi/spnego/gssapiP_spnego.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ typedef struct {
int firstpass;
int mech_complete;
int nego_done;
int initiate;
int opened;
OM_uint32 ctx_flags;
gss_name_t internal_name;
gss_OID actual_mech;
Expand Down
Loading

0 comments on commit b51b33f

Please sign in to comment.