Fix LDAP policy enforcement of pw_expiration #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghudson
requested changes
Dec 18, 2019
frozencemetery
force-pushed
the
ldap_pw_expiration
branch
4 times, most recently
from
7c83052
to
a48b0d1
Compare
greghudson
requested changes
Dec 30, 2019
frozencemetery
force-pushed
the
ldap_pw_expiration
branch
2 times, most recently
from
bb4845e
to
f087c2f
Compare
|
Rebased and addressed comments. |
greghudson
force-pushed
the
ldap_pw_expiration
branch
from
f087c2f
to
bc523b9
Compare
In the LDAP backend, the change mask is used to determine what LDAP attributes to update. As a result, password expiration was not set from policy when running during addprinc, among other issues. However, when the mask did not contain KADM5_PRINCIPAL, pw_expiration would be applied regardless, which meant that (for instance) changing the password would cause the password application to be applied. Remove the check for KADM5_PRINCIPAL, and fix the mask to contain KADM5_PW_EXPIRATION where appropriate. Add a regression test to t_kdb.py. [ghudson@mit.edu: also set KADM5_ATTRIBUTES for randkey and setkey since they both unset KRB5_KDB_REQUIRES_PWCHANGE; edited comments and commit message] ticket: 8861 (new) tags: pullup target_version: 1.17-next
greghudson
force-pushed
the
ldap_pw_expiration
branch
from
bc523b9
to
6b004dd
Compare
greghudson
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In only the LDAP backend, the change mask is used to determine what to
update. As a result, password expiration was not set from policy when
running during addprinc, among other issues. However, when the mask did
not contain KADM5_PRINCIPAL, pw_expiration would be applied regardless,
which meant that (for instance) changing the password would cause the
password application to be applied.
Remove this check, and fix the mask to contain KADM5_PW_EXPIRATION where
appropriate. Add a regression test to the LDAP suite.