Use SHA-256 instead of SHA-1 for PKINIT CMS digest #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghudson
force-pushed
the
pkinit_cms_sha256
branch
from
b654b8d
to
b13284e
Compare
[ghudson@mit.edu: edited comments] ticket: 9055 (new)
greghudson
force-pushed
the
pkinit_cms_sha256
branch
from
b13284e
to
cbfe46c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various organizations including NIST have been strongly recommending to stop using SHA-1 for digital signatures for some years already. CMS digest is used to generate such signatures, hence it should be upgraded to use SHA-256.
This change has already been implemented in Heimdal.