Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in aclocal.m4 #1272

Merged
merged 1 commit into from Nov 18, 2022
Merged

Fix syntax error in aclocal.m4 #1272

merged 1 commit into from Nov 18, 2022

Conversation

jrisc
Copy link
Contributor

@jrisc jrisc commented Nov 17, 2022

The block argument of the AC_CACHE_VAL call ends before the if instruction can reach the corresponding fi one. This fi is definitely meant to be part of this block.

@greghudson
Copy link
Member

Looking at the history, this mistake has been present since 2000. I think the only practical consequence is that the AC_CACHE_VAL cleanup rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext winds up being conditional upon $ac_cv_func_inet_ntop" = "yes". How did you notice it? (I will accept the patch, of course, but whether it gets a ticket and backport depends on whether it has a more significant practical consequence in some environment.)

@jrisc
Copy link
Contributor Author

jrisc commented Nov 18, 2022

This problem was identified by Frédéric Bérat while testing the upcoming version 2.72 of Autoconf on the Fedora build of krb5.

The error message is:

checking for IPv6 compile-time support without -DINET6... ./configure: line 10559: syntax error near unexpected token `;;'
./configure: line 10559: `rm -f core conftest.err conftest.$ac_objext conftest.beam conftest.$ac_ext ;;'

An incorrect closure inside KRB5_AC_INET6 is innocuous with autoconf
versions up to 2.71, but will cause an error at configure time with
the forthcoming autoconf 2.72.

[ghudson@mit.edu: added more context to commit message]

ticket: 9077 (new)
tags: pullup
target_version: 1.20-next
target_version: 1.19-next
@greghudson greghudson merged commit d864d74 into krb5:master Nov 18, 2022
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants