New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow retries on SOCK_STREAM sockets in libkrad #308

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@npmccallum
Contributor

npmccallum commented Aug 7, 2015

Before this patch, libkrad would follow the same exact logic for
all socket types when the retries parameter was non-zero. This
meant that when connecting with SOCK_STREAM, multiple requests
were sent in case of packet drops, which, of course, cannot
happen for SOCK_STREAM.

Instead, we will just disable retries for SOCK_STREAM sockets.

Do not allow retries on SOCK_STREAM sockets in libkrad
Before this patch, libkrad would follow the same exact logic for
all socket types when the retries parameter was non-zero. This
meant that when connecting with SOCK_STREAM, multiple requests
were sent in case of packet drops, which, of course, cannot
happen for SOCK_STREAM.

Instead, we will just disable retries for SOCK_STREAM sockets.
@greghudson

This comment has been minimized.

Show comment
Hide comment
@greghudson

greghudson Aug 7, 2015

Member

Pushed to master with minor changes as 25e0656

Member

greghudson commented Aug 7, 2015

Pushed to master with minor changes as 25e0656

@greghudson greghudson closed this Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment