Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OTP sockets to KDCRUN_DIR #45

Closed
wants to merge 1 commit into from
Closed

Conversation

npmccallum
Copy link
Contributor

No description provided.

@tlyu
Copy link
Member

tlyu commented Feb 5, 2014

I have a slight preference for KDC_RUNDIR, but I haven't looked at prevailing practices for this naming convention.

@greghudson
Copy link
Member

My preference is KDC_RUN_DIR.

The documentation needs to be updated. To do this, we will need a new substitution in src/doc/Makefile.in and doc/conf.py.

On IRC, Nathaniel noted that this changes the default socket directory with no fallback, and that runtime fallback code would be difficult. I think I am okay with that, but we will need a 1.13 release note about it.

@greghudson greghudson closed this Feb 5, 2014
@greghudson greghudson reopened this Feb 5, 2014
@npmccallum
Copy link
Contributor Author

I just pushed a new version which should address these issues.

@npmccallum
Copy link
Contributor Author

I should mention that while this changes the default socket directory with no fallback, configured token types that specify a socket path will not be affected by this change. This only applies to the implicitly defined sockets. I am probably the only person using this.

@npmccallum
Copy link
Contributor Author

I just made one more push. This change is to src/Makefile.in so that make install will create KDC_RUN_DIR. Doing this ensures that, in package managers, this directory is properly owned by the KDC.

@greghudson
Copy link
Member

I think src/man/Makefile.in and doc/mitK5defaults.rst also need to be updated.

@greghudson
Copy link
Member

Also, while I see support for the new substitution, I don't see anything actually using it; otp.rst is unchanged and still references $KDCDIR (which is an odd kind of shorthand since it's not an environment variable and $ substitutions don't work in that context).

@npmccallum
Copy link
Contributor Author

That push fixes src/man/Makefile.in and doc/mitK5defaults.rst. I'm not quite sure what I should do in otp.rst. Hints are welcome.

@npmccallum
Copy link
Contributor Author

This version adds support for proper substitution to otp.rst.

@greghudson
Copy link
Member

I wasn't specific enough when I said mitK5defaults.rst needed to be updated; the part I meant was the table giving defaults for BINDIR/LIBDIR/etc.. Otherwise if you follow the link from RUNSTATEDIR in otp.html, you just see a table which says nothing about RUNSTATEDIR.

@npmccallum
Copy link
Contributor Author

Does that solve the problem?

@npmccallum
Copy link
Contributor Author

This commit moves /var/run to /run. This is because the Linux world has standardized on the latter.

@greghudson
Copy link
Member

In the mitK5defaults.rst table, use "Parent of KDC runtime dir" to avoid overrunning the column width and having to extend the column.

In otp.rst, use |kdcrundir|\ /<name>.socket for the default socket path to get correct formatting.

@npmccallum
Copy link
Contributor Author

Fixed.

@greghudson
Copy link
Member

Pushed to master with small changes to otp.rst.

@greghudson greghudson closed this Feb 6, 2014
@npmccallum npmccallum deleted the sockdir branch January 12, 2015 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants