Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/preauth/pkinit Fix build with LibreSSL #607

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Sp1l
Copy link

commented Feb 12, 2017

  • LibreSSL defines OPENSSL_VERSION_NUMBER 0x20000000L
  • Add check for LIBRESSL_VERSION_NUMBER for checks >= 1.1.0

See also HardenedBSD/hardenedbsd-ports@fc7b152
See also https://bugs.freebsd.org/217027

plugins/preauth/pkinit Fix build with LibreSSL
  - LibreSSL defines OPENSSL_VERSION_NUMBER 0x20000000L
  - Add check for LIBRESSL_VERSION_NUMBER for checks >= 1.1.0

See also HardenedBSD/hardenedbsd-ports@fc7b152
See also https://bugs.freebsd.org/217027
@greghudson

This comment has been minimized.

Copy link
Member

commented Feb 15, 2017

I've had some discussion with colleagues about whether applications should accomodate LibreSSL's choice to define OPENSSL_VERSION to correspond to release 2.0. Several of them said that they shouldn't, in order to push back on a bad decision rather than bear the pain of that decision in application code. I haven't come to a definite conclusion.

If we do accept this change, we probably want an intermediate symbol to indicate the OpenSSL 1.1 API, instead of a composite test in three different places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.