From d8b07eacdb355d596b177d2faa70c23ff0d695e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Gamez?= <jerome@gamez.name>
Date: Wed, 7 Aug 2019 18:42:43 +0200
Subject: [PATCH] Mark ApiExceptionConverters as internal, remove interface

---
 src/Firebase/Exception/AuthApiExceptionConverter.php |  8 +++++++-
 .../Exception/DatabaseApiExceptionConverter.php      |  8 +++++++-
 src/Firebase/Exception/ExceptionConverter.php        | 12 ------------
 .../Exception/MessagingApiExceptionConverter.php     |  8 +++++++-
 .../Exception/RemoteConfigApiExceptionConverter.php  |  8 +++++++-
 5 files changed, 28 insertions(+), 16 deletions(-)
 delete mode 100644 src/Firebase/Exception/ExceptionConverter.php

diff --git a/src/Firebase/Exception/AuthApiExceptionConverter.php b/src/Firebase/Exception/AuthApiExceptionConverter.php
index d52df484..1e656468 100644
--- a/src/Firebase/Exception/AuthApiExceptionConverter.php
+++ b/src/Firebase/Exception/AuthApiExceptionConverter.php
@@ -22,11 +22,17 @@
 use Kreait\Firebase\Http\ErrorResponseParser;
 use Throwable;
 
-final class AuthApiExceptionConverter implements ExceptionConverter
+/**
+ * @internal
+ */
+class AuthApiExceptionConverter
 {
     /** @var ErrorResponseParser */
     private $responseParser;
 
+    /**
+     * @internal
+     */
     public function __construct()
     {
         $this->responseParser = new ErrorResponseParser();
diff --git a/src/Firebase/Exception/DatabaseApiExceptionConverter.php b/src/Firebase/Exception/DatabaseApiExceptionConverter.php
index a5ab79ca..02cad7f3 100644
--- a/src/Firebase/Exception/DatabaseApiExceptionConverter.php
+++ b/src/Firebase/Exception/DatabaseApiExceptionConverter.php
@@ -12,11 +12,17 @@
 use Kreait\Firebase\Http\ErrorResponseParser;
 use Throwable;
 
-final class DatabaseApiExceptionConverter implements ExceptionConverter
+/**
+ * @internal
+ */
+class DatabaseApiExceptionConverter
 {
     /** @var ErrorResponseParser */
     private $responseParser;
 
+    /**
+     * @internal
+     */
     public function __construct()
     {
         $this->responseParser = new ErrorResponseParser();
diff --git a/src/Firebase/Exception/ExceptionConverter.php b/src/Firebase/Exception/ExceptionConverter.php
deleted file mode 100644
index 26ae1300..00000000
--- a/src/Firebase/Exception/ExceptionConverter.php
+++ /dev/null
@@ -1,12 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace Kreait\Firebase\Exception;
-
-use Throwable;
-
-interface ExceptionConverter
-{
-    public function convertException(Throwable $exception): FirebaseException;
-}
diff --git a/src/Firebase/Exception/MessagingApiExceptionConverter.php b/src/Firebase/Exception/MessagingApiExceptionConverter.php
index bc91deb6..ea4ddbf7 100644
--- a/src/Firebase/Exception/MessagingApiExceptionConverter.php
+++ b/src/Firebase/Exception/MessagingApiExceptionConverter.php
@@ -16,11 +16,17 @@
 use Kreait\Firebase\Http\ErrorResponseParser;
 use Throwable;
 
-class MessagingApiExceptionConverter implements ExceptionConverter
+/**
+ * @internal
+ */
+class MessagingApiExceptionConverter
 {
     /** @var ErrorResponseParser */
     private $responseParser;
 
+    /**
+     * @internal
+     */
     public function __construct()
     {
         $this->responseParser = new ErrorResponseParser();
diff --git a/src/Firebase/Exception/RemoteConfigApiExceptionConverter.php b/src/Firebase/Exception/RemoteConfigApiExceptionConverter.php
index 6b90888d..dd48dc94 100644
--- a/src/Firebase/Exception/RemoteConfigApiExceptionConverter.php
+++ b/src/Firebase/Exception/RemoteConfigApiExceptionConverter.php
@@ -11,11 +11,17 @@
 use Kreait\Firebase\Http\ErrorResponseParser;
 use Throwable;
 
-class RemoteConfigApiExceptionConverter implements ExceptionConverter
+/**
+ * @internal
+ */
+class RemoteConfigApiExceptionConverter
 {
     /** @var ErrorResponseParser */
     private $responseParser;
 
+    /**
+     * @internal
+     */
     public function __construct()
     {
         $this->responseParser = new ErrorResponseParser();