Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct ID token verification #151

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

jeromegamez
Copy link
Member

:octocat:

@jeromegamez
Copy link
Member Author

@hernandev Could you please have a look at this?

@hernandev
Copy link

are you using the child package or imported the code into this one?

@hernandev
Copy link

Could not find where the Token\Domain is comming from

@jeromegamez
Copy link
Member Author

Yes, I'm using the kreait/firebase-tokens-php: https://github.com/kreait/firebase-tokens-php/blob/master/src/Domain/Verifier.php

It's the Verifier interface, I then inject the implementation in the factory.

@hernandev
Copy link

@jeromegamez I'm good then. gonna drop you an email now, if that's ok.

Thanks for such a fast fix.

@hernandev
Copy link

@jeromegamez I'm available to finish it up testing after upgrade to ensure it's all good.

Your email is not public, so just say hi at diego@hernandev.com just for me to tell you some quick tips

@jeromegamez jeromegamez merged commit 27470b9 into master Jan 16, 2018
@jeromegamez jeromegamez deleted the bugfix/id-token-verification branch January 16, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants