Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issue with missing dom_id param #51

Merged
merged 1 commit into from Oct 22, 2012

Conversation

2 participants
Contributor

pehlert commented Oct 21, 2012

When the dom_id query param was missing in the file browser params, a JavaScript error occurred because split("_") was called on a null object. I have not investigated this in depth, but it could be due to a recent change to jQuery. The version used in my test was 1.8.2

@bastiaanterhorst bastiaanterhorst added a commit that referenced this pull request Oct 22, 2012

@bastiaanterhorst bastiaanterhorst Merge pull request #51 from pehlert/master
Fix issue with missing dom_id param
858c96a

@bastiaanterhorst bastiaanterhorst merged commit 858c96a into kreativgebiet:master Oct 22, 2012

Contributor

bastiaanterhorst commented Oct 22, 2012

Thanks! The issue actually arose when implementing support for linking objects (instead of returning string urls).

Contributor

pehlert commented Oct 22, 2012

Hi Bastiaan,

Thanks for the immediate action, glad to see well maintained projects!
Keep up the great work!

Cheers,

Pascal

On Oct 22, 2012, at 7:28 AM, Bastiaan Terhorst notifications@github.com wrote:

Thanks! The issue actually arose when implementing support for linking objects (instead of returning string urls).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment