Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong page title when navigating #11

Closed
julien1619 opened this Issue Jan 8, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@julien1619
Copy link
Contributor

julien1619 commented Jan 8, 2019

When navigating, the page title is not correctly set in Matomo, the pathname is sent instead.

window._paq.push(['setDocumentTitle', pathname])

I'm using React Helmet to set my title, so the question is: is the title already updated when onRouteUpdate is called? If yes, maybe we could get the document title and it should be good for every usecase.

@kremalicious

This comment has been minimized.

Copy link
Owner

kremalicious commented Mar 30, 2019

Hey! Indeed this would be nice. But page title can't be reliably detected which is why I choose to simply push the path for it:

kremalicious added a commit that referenced this issue Mar 30, 2019

capture and send custom page title
* workaround to delay page tracking until react-helmet is finished updating document.title
* closes #11
@kremalicious

This comment has been minimized.

Copy link
Owner

kremalicious commented Mar 30, 2019

Fix released in v0.7.0, should be working now™

@julien1619

This comment has been minimized.

Copy link
Contributor Author

julien1619 commented Apr 3, 2019

I can confirm, it works very well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.