Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing tracking code in rendered HTML #18

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@julien1619
Copy link
Contributor

commented Jun 13, 2019

onRenderBody does take any return type, I removed the useless return null at the end of this function.
setHeadComponents doesn't return anything so the right side of the && wasn't executed, only the head was built.

Fix missing tracking code in rendered HTML
`onRenderBody` does take any return type, I removed the useless `return null` at the end of this function.
`setHeadComponents` doesn't return anything so the right side of the `&&` wasn't executed, only the `head` was built.
@kremalicious

This comment has been minimized.

Copy link
Owner

commented Jun 13, 2019

Excellent, thanks!

@kremalicious kremalicious merged commit d5338b2 into kremalicious:master Jun 13, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.