Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trackAllContentImpressions to record/enable content tracking #19

Merged
merged 1 commit into from Feb 15, 2020

Conversation

@Jedidiah
Copy link
Contributor

Jedidiah commented Jul 9, 2019

Thank you for this plugin!

This PR adds _paq.push(['trackAllContentImpressions']); after trackPageView to record content impressions on the new page.

More details at https://developer.matomo.org/guides/content-tracking

@Jedidiah

This comment has been minimized.

Copy link
Contributor Author

Jedidiah commented Jul 9, 2019

@kremalicious The code climate failure isn't related to the changed code. Would you like me to add their suggestion anyway to get it passing?

Copy link
Owner

kremalicious left a comment

thanks! Sorry for late reply

@kremalicious kremalicious merged commit 4ee4c92 into kremalicious:master Feb 15, 2020
1 of 2 checks passed
1 of 2 checks passed
codeclimate 1 issue to fix
Details
Travis CI - Pull Request Build Passed
Details
@Jedidiah Jedidiah deleted the Jedidiah:track-content branch Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.