Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoping js variables to avoid polluting global scope #6

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
2 participants
@julien1619
Copy link
Contributor

commented Jul 29, 2018

I've updated the tracking code with the latest generated by Matomo. The main difference resides in the scoping of variables declared when inserting the <script> tag. Previously it was polluting the global scope and wasn't recommended.

@kremalicious

This comment has been minimized.

Copy link
Owner

commented Aug 6, 2018

awesome, thanks! 🙏

@kremalicious kremalicious merged commit 226115d into kremalicious:master Aug 6, 2018

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.