From 4ded05e8e210927e7dcecb5360cecb9b9e1f6b06 Mon Sep 17 00:00:00 2001 From: Antoine BOSSY Date: Wed, 8 Aug 2018 20:56:41 +0200 Subject: [PATCH] Delete dead code. Fixes #770 --- client/store/backend.js | 8 -------- server/controllers/v1/accesses.js | 10 ---------- server/controllers/v1/accounts.js | 11 ----------- server/controllers/v1/routes.js | 6 ------ server/models/requests.js | 4 +--- 5 files changed, 1 insertion(+), 38 deletions(-) diff --git a/client/store/backend.js b/client/store/backend.js index 6f9700222..b6892a928 100644 --- a/client/store/backend.js +++ b/client/store/backend.js @@ -92,20 +92,12 @@ export function init() { }); } -export function getAccounts(accessId) { - return buildFetchPromise(`api/${API_VERSION}/accesses/${accessId}/accounts`); -} - export function deleteAccess(accessId) { return buildFetchPromise(`api/${API_VERSION}/accesses/${accessId}`, { method: 'DELETE' }); } -export function getOperations(accountId) { - return buildFetchPromise(`api/${API_VERSION}/accounts/${accountId}/operations`); -} - export function deleteOperation(opId) { return buildFetchPromise(`api/${API_VERSION}/operations/${opId}`, { method: 'DELETE' diff --git a/server/controllers/v1/accesses.js b/server/controllers/v1/accesses.js index 894fa33e7..e8aee63ae 100644 --- a/server/controllers/v1/accesses.js +++ b/server/controllers/v1/accesses.js @@ -24,16 +24,6 @@ export async function preloadAccess(req, res, next, accessId) { } } -// Returns accounts bound to a given access. -export async function getAccounts(req, res) { - try { - let accounts = await Account.byAccess(req.preloaded.access); - res.status(200).json(accounts); - } catch (err) { - return asyncErr(err, res, 'when getting accounts for a bank'); - } -} - // Destroy a given access, including accounts, alerts and operations. export async function destroy(req, res) { try { diff --git a/server/controllers/v1/accounts.js b/server/controllers/v1/accounts.js index b2c07b080..b4e06cbf5 100644 --- a/server/controllers/v1/accounts.js +++ b/server/controllers/v1/accounts.js @@ -84,17 +84,6 @@ export async function destroy(req, res) { } } -// Get operations of a given bank account -export async function getOperations(req, res) { - try { - let account = req.preloaded.account; - let operations = await Operation.byBankSortedByDate(account); - res.status(200).json(operations); - } catch (err) { - return asyncErr(res, err, 'when getting operations for a bank account'); - } -} - export async function resyncBalance(req, res) { try { let account = req.preloaded.account; diff --git a/server/controllers/v1/routes.js b/server/controllers/v1/routes.js index 8f5f0f931..9f4d6947d 100644 --- a/server/controllers/v1/routes.js +++ b/server/controllers/v1/routes.js @@ -33,9 +33,6 @@ const routes = { put: accesses.update, delete: accesses.destroy }, - 'accesses/:accessId/accounts': { - get: accesses.getAccounts - }, 'accesses/:accessId/fetch/operations': { get: accesses.fetchOperations }, @@ -51,9 +48,6 @@ const routes = { put: accounts.update, delete: accounts.destroy }, - 'accounts/:accountId/operations': { - get: accounts.getOperations - }, 'accounts/:accountId/resync-balance': { get: accounts.resyncBalance }, diff --git a/server/models/requests.js b/server/models/requests.js index 0cb09c1b9..2cd6fa935 100644 --- a/server/models/requests.js +++ b/server/models/requests.js @@ -12,7 +12,6 @@ function allReportsByFrequency() { emit([doc.type, doc.frequency], doc); } function allByBankAccountAndType() { emit([doc.accountId, doc.type], doc); } function allByBankAccountAndDate() { emit([doc.accountId, doc.date], doc); } function allAccessesLike() { emit([doc.bank, doc.login, doc.password], doc); } -function allAccountsLike() { emit([doc.bank, doc.accountNumber], doc); } function allOperationsLike() { emit([doc.accountId, doc.date, doc.amount.toFixed(2), doc.raw], doc); } function allWithOperationTypesId() { if (doc.hasOwnProperty('operationTypeID')) { emit(doc._id, doc); } } /* eslint-enable */ @@ -33,8 +32,7 @@ module.exports = { all: cozydb.defaultRequests.all, allByAccountIds, allByBankAccess, - allByBank, - allLike: allAccountsLike + allByBank }, operation: {