New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support useStyles(style) for Hooks #159
Conversation
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 80.76% 80.95% +0.18%
==========================================
Files 3 4 +1
Lines 52 63 +11
Branches 12 15 +3
==========================================
+ Hits 42 51 +9
- Misses 9 11 +2
Partials 1 1
Continue to review full report at Codecov.
|
Glad if you take a look at this, @frenzzy . |
I think all react-related stuff should be moved away from |
@frenzzy Thank you for the information, that's a good discussion. Yes, I'll follow decision the issue will make. Or, we can move withStyles and useStyles together later, since useStyles is just another implementation of withStyles. |
@frenzzy Do you have a plan to separate the package into a loader and a react binding? That would be a breaking change. Would you like me to create the PR? |
Agreed. Let's do this, I will release it as
It would be nice to split them, but I don't have time to do it. Need to create another repo for react bindings, configure builds, write tests etc. After that make a PR to |
Released as v5.1.0 🎉 |
Thank you frenzzy. Yeah, that is going to be some work. I see, you're thinking another GitHub repo for it. I think I'll give it a try in the next free weekends. |
@frenzzy Instead of separating the repo, what would you say if we about monorepo with Lerna? Pros
Cons
|
We finished this talk on #160 (comment) |
Fixes #154.
I'm glad if you take a look this, @frenzzy .