Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null same way as undefined #51

Merged
merged 4 commits into from Oct 9, 2016
Merged

Conversation

@langpavel
Copy link
Collaborator

langpavel commented Oct 6, 2016

  • Handle null same way as undefined
  • Return null instead of undefined to signal no match. (BREAKING CHANGE)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage remained the same at 88.406% when pulling c0d95ef on langpavel:not-match-is-null into e3c51de on kriasoft:master.

langpavel added 4 commits Oct 6, 2016
@langpavel langpavel force-pushed the langpavel:not-match-is-null branch from c0d95ef to 9d5d0c4 Oct 6, 2016
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 6, 2016

Coverage Status

Coverage increased (+0.2%) to 88.889% when pulling 9d5d0c4 on langpavel:not-match-is-null into f3a7c2f on kriasoft:master.

### [v1.3.0] - [unreleased]

- Handle `null` same way as `undefined`
- Return `null` instead of `undefined` to signal no match. (BREAKING CHANGE)

This comment has been minimized.

Copy link
@frenzzy

frenzzy Oct 7, 2016

Member

Please, follow the semantic versioning.

This comment has been minimized.

Copy link
@langpavel

langpavel Oct 7, 2016

Author Collaborator

@frenzzy It's not so breaking.. API remains same but behavior is slightly modified. What you mean by follow semver? I think shift up minor in this case is fine.

@koistya What you think?

This comment has been minimized.

Copy link
@langpavel

langpavel Oct 7, 2016

Author Collaborator

From semver:

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backwards compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.

I think this is the case

@koistya koistya merged commit 9740ad0 into kriasoft:master Oct 9, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 88.889%
Details
@langpavel langpavel deleted the langpavel:not-match-is-null branch Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.